Improve FakeTimeProvider documentation, remove redundant tests #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor tests methods
amadeuszl
changed the title
eduherminio
approved these changes
Nov 21, 2024
src/Libraries/Microsoft.Extensions.TimeProvider.Testing/README.md
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.TimeProvider.Testing/README.md
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Nov 21, 2024
src/Libraries/Microsoft.Extensions.TimeProvider.Testing/README.md
Outdated
Show resolved
Hide resolved
RussKie
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
FakeTimeProviderdocumentation, remove redundant tests, refactor tests methods.I updated test method names as well to make them more readable, so that the code can also serve as nice documentation and reference to the users.
Microsoft Reviewers: Open in CodeFlow