Add constraints for ^Step param type in ranges in (.. ..) operators

docs/release-notes/.FSharp.Core/8.0.400.md

@@ -6,3 +6,4 @@
 
 * Cache delegate in query extensions. ([PR #17130](https://github.com/dotnet/fsharp/pull/17130))
 * Update `AllowNullLiteralAttribute` to also use `AttributeTargets.Interface` ([PR #17173](https://github.com/dotnet/fsharp/pull/17173))
+* Missing constraints added for `^Step` parameter in range expressions for `(.. ..)` operator ([PR #17133](https://github.com/dotnet/fsharp/pull/17133))

src/FSharp.Core/prim-types.fsi

@@ -3758,6 +3758,8 @@ namespace Microsoft.FSharp.Core
                                 and ^Step: (static member Zero: ^Step)
                                 and ^T: equality
                                 and ^T: comparison                                
+                                and ^Step: equality
+                                and ^Step: comparison                                
                                 and default ^Step: ^T
                                 and default ^T: int
 

tests/FSharp.Core.UnitTests/FSharp.Core/PrimTypes.fs

@@ -1132,6 +1132,33 @@
             if System.UIntPtr.Size >= 8 then
                 RangeTestsHelpers.unsigned 0x0un 0x1un 0x0un 0xffffffffffffffffun
 
+    [<AutoOpen>]
+    module UserDefinedRange =
+        type Step(value:int) =
+            member __.Value = value
+
+            static member Zero = Step 0
+
+        type Value(value:int) =
+            member __.Value = value
+
+            static member (+)(a:Value, b:Step) = Value(a.Value + b.Value)
+
+            interface System.IComparable with
+                member a.CompareTo(b) =
+                    match b with
+                    | :? Value as b' -> compare a.Value b'.Value
+                    | _ -> failwith "unsupported"
+
+        [<Fact>]
+        let ``Range.UserDefined``() =
+            // using a user defined type, as opposed to a primitive, as the base type
+            let rangeList = [Value 0 .. Step 2 .. Value 2]
+            let rangeArray = [Value 0 .. Step 2 .. Value 2]
+            Assert.AreEqual(2, rangeList.Length)
+            Assert.AreEqual(2, rangeArray.Length)
+
+
     /// These tests' arguments are intentionally _not_ inlined
     /// to force the size of the collection (for lists and arrays) or count (for for-loops) to be computed at runtime.
     module Runtime =
@@ -1216,6 +1243,13 @@
                 let zero, one, min0, max0 =  System.UIntPtr 0u, System.UIntPtr 1u, System.UIntPtr System.UInt64.MinValue, System.UIntPtr System.UInt64.MaxValue
                 RangeTestsHelpers.unsigned zero one min0 max0
 
+        [<Fact>]
+        let ``Range.UserDefined``() =
+            let rangeList = [Value 0 .. Step 2 .. Value 2]
+            let rangeArray = [Value 0 .. Step 2 .. Value 2]
+            Assert.AreEqual(2, rangeList.Length)
+            ()
+
 open NonStructuralComparison