-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fix for issues caused by setting Shell.FlyoutWidth on WinUI when binding context values are changed #27151
base: main
Are you sure you want to change the base?
[Windows] Fix for issues caused by setting Shell.FlyoutWidth on WinUI when binding context values are changed #27151
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -128,13 +128,14 @@ void ShellElementPropertyChanged(object sender, PropertyChangedEventArgs e) | |||
|
|||
protected override global::Windows.Foundation.Size ArrangeOverride(global::Windows.Foundation.Size finalSize) | |||
{ | |||
base.ArrangeOverride(finalSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include an UITest and use get the Label counter value to validate it with an Assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, ensuring this through an assert was not functioning properly in this scenario, possibly because the text only disappeared from the view. As a result, the test passed without this fix. I have added a UI test with VerifyScreenshot to address the issue. Could you please review it and share your feedback?
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #19496
Fixes #23214
Tested the behaviour in the following platforms
Screenshot
Before-Fix-FL-Width.mp4
After-Fix-FL-Width.mp4