Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Fix for WebView flaky tests in CI which fails due to network connectivity. #27178

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Testing] Fix for WebView flaky tests in CI which fails due to network connectivity. #27178

wants to merge 11 commits into from

Conversation

anandhan-rajagopal
Copy link
Contributor

Description

This PR includes a boolean property called "IsInternetRequired" to the IssueAttribute, aimed at simplifying the management of test cases that necessitate internet access.

  • The new implementation centralizes the logic for checking internet connectivity, presents a "No Internet Connection" page when applicable, and enables easier detection of connectivity issues within the test runner.
  • Additionally, it allows these tests to be marked as skipped with Assert.Inconclusive in the overridden TestSetup Method. This enhancement improves code maintainability, increases the flexibility of test cases, and establishes a consistent method for addressing internet-dependent test scenarios throughout the application.
  • The approach for marking tests as Inconclusive is referenced from UITest setups from Xamarin.Forms: https://github.com/xamarin/Xamarin.Forms/blob/2f8f4864a4d289dc89a6228e2ca9d6a49993e365/Xamarin.Forms.Core.UITests.Shared/BaseTestFixture.cs#L50

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 16, 2025
@anandhan-rajagopal anandhan-rajagopal added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jan 16, 2025
@anandhan-rajagopal anandhan-rajagopal marked this pull request as ready for review January 16, 2025 13:39
@anandhan-rajagopal anandhan-rajagopal requested a review from a team as a code owner January 16, 2025 13:39
@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR4 milestone Jan 16, 2025
jsuarezruiz
jsuarezruiz previously approved these changes Jan 17, 2025
View reviewed changes
@anandhan-rajagopal @MartyIX
Update src/Controls/tests/TestCases.HostApp/CoreViews/NoInternetConne…
5ed0c5c 
…ctionPage.cs


Addressed review correction

Co-authored-by: MartyIX <[email protected]>
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyIX MartyIX MartyIX left review comments

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@jsuarezruiz jsuarezruiz

Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
MAUI SDK Ongoing
Status: Approved
Milestone
.NET 9 SR4
Development

Successfully merging this pull request may close these issues.
6 participants
@anandhan-rajagopal @rmarinho @jsuarezruiz @MartyIX @PureWeen @NafeelaNazhir