Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Trigger OnNavigatedTo method when hide the nav bar and using swipe gesture #27186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[iOS] Trigger OnNavigatedTo method when hide the nav bar and using swipe gesture #27186

wants to merge 2 commits into from
+95 −0

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jan 16, 2025

Issues Fixed

Fixes #27143

@kubaflo kubaflo requested a review from a team as a code owner January 16, 2025 16:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 16, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a test?

kubaflo
kubaflo commented Jan 17, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27143.cs
{
App.WaitForElement("button");
App.Click("button");
// Find a way to perform swipe to navigate back
Copy link
Contributor Author

@kubaflo kubaflo Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz do you have some idea of how we can do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anandhan-rajagopal maybe you can help here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-navigation NavigationPage community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not trigger OnNavigatedTo method when hide the navi bar and using swipe back on iOS
3 participants
@kubaflo @jfversluis @jsuarezruiz