[iOS] SwipeView: SwipeItem.IconImageSource.FontImageSource color value not honored - fix #27389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/iOS 🍎
community ✨
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This comment was marked as off-topic.
This comment was marked as off-topic.
jsuarezruiz
added
area-controls-swipeview
This comment was marked as off-topic.
This comment was marked as off-topic.
jsuarezruiz
requested changes
Jan 28, 2025
src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
Outdated
Show resolved
Hide resolved
|
@jsuarezruiz can you please /azp again? |
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
SwipeView-SwipeItem.IconImageSource.FontImageSource-color-value-not-honored
branch
from
a71dd78 to
6412c62
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Feb 12, 2025
| { | ||
| App.WaitForElement("Button"); | ||
| App.Click("Button"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Failing on Android:
Snapshot different than baseline: FontImageSourceShouldHonorColor.png (0.99% difference)
Small differences, I think could be related with #27179
Could you review it and update the snapshot if necessary?
There was a problem hiding this comment.
Yea that was it. Snapshot updated
kubaflo
force-pushed
the
SwipeView-SwipeItem.IconImageSource.FontImageSource-color-value-not-honored
branch
from
6412c62 to
9b36f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Replaced
UIImageRenderingMode.AlwaysTemplatewithUIImageRenderingMode.AutomaticIssues Fixed
Fixes #27377