Add BCrypt types and test for CCM block chaining mode #74
Conversation
| /// The Microsoft algorithm providers for Advanced Encryption Standard (AES) | ||
| /// require a nonce for the Counter with CBC-MAC (CCM) and Galois/Counter Mode (GCM) | ||
| /// chaining modes, and will return an error if none is present. | ||
| /// If a nonce is not used, this member must be set to NULL. |
There was a problem hiding this comment.
I don't know what we should do about documentation in cases like that, I replaced NULL with <see cref="IntPtr.Zero" /> in a few places but that's tedious.
That's just a detail but might be interesting to unify on it at some point (Maybe a big XML doc cleanup before we reach 1.0).
There was a problem hiding this comment.
Ya, in all my xml doc comment fixups (adding see cref's etc.) I haven't bothered fixing references to NULL. Sometimes it will be IntPtr.Zero. Other times it will be null. While the doc would be cleaner, I figure unless there's an automated way to fix it up, it's probably not worth our time since readers should be able to figure out what it means.
There was a problem hiding this comment.
I don't think there is a good way to make it automated but it could be made assisted, also the point is moot if we decide to do pointer only or to codegen the IntPtr variants.
Add BCrypt types and test for CCM block chaining mode
No description provided.