implement GetHashCode instead of throwing (#4758)

implement GetHashCode instead of throwing
dotnet · Apr 29, 2019 · 8061e7b · 8061e7b
2 parents 9a8bf7b + 0299cb7
commit 8061e7b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -34,6 +34,8 @@
 
     <!-- Prevent vsix manifests from being copied to the shared output directory, makes build more deterministic -->
     <CopyVsixManifestToOutput>false</CopyVsixManifestToOutput>
+
+    <NoWarn>$(NoWarn);NU5125</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Microsoft.VisualStudio.Editors/PropPages/WPF/ApplicationPropPageVBWPF.vb b/src/Microsoft.VisualStudio.Editors/PropPages/WPF/ApplicationPropPageVBWPF.vb
@@ -930,7 +930,7 @@ Namespace Microsoft.VisualStudio.Editors.PropertyPages.WPF
             End Function
 
             Public Overrides Function GetHashCode() As Integer
-                Throw New NotImplementedException()
+                Return -1937169414 + StringComparer.OrdinalIgnoreCase.GetHashCode(Value)
             End Function
 
         End Class
@@ -964,7 +964,10 @@ Namespace Microsoft.VisualStudio.Editors.PropertyPages.WPF
             End Function
 
             Public Overrides Function GetHashCode() As Integer
-                Throw New NotImplementedException()
+                Dim hashCode = 870297925
+                hashCode = hashCode * -1521134295 + MyBase.GetHashCode()
+                hashCode = hashCode * -1521134295 + IsEquivalentToSubMain.GetHashCode()
+                Return hashCode
             End Function
 
         End Class