Skip to content

Commit

Permalink
Merge pull request #9411 from drewnoakes/fix-warning-and-net8-code
Browse files Browse the repository at this point in the history
Fix two compilation warnings in the solution
  • Loading branch information
drewnoakes authored Mar 9, 2024
2 parents b1e00e4 + e566912 commit fd6ac06
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ protected internal virtual ProjectTreeFlags UpdateTreeFlags(string id, ProjectTr
/// Gets the <see cref="DiagnosticLevel"/> to set for a dependency, based on its resolved state and item properties.
/// </summary>
/// <param name="isResolved"><see langword="true"/> if the dependency is resolved, <see langword="false"/> if it is unresolved, or <see langword="null"/> if the status is not yet determined.</param>
/// <param name="hasBuildError">Whether the MSBuild invocation that produced this data also encountered an error or not.</param>
/// <param name="properties">The properties of the item.</param>
/// <param name="defaultLevel">The diagnostic level to use when the property is either missing or empty. Intended to receive a dependency's current diagnostic level when an evaluation-only update is being processed.</param>
/// <returns></returns>
Expand Down
4 changes: 4 additions & 0 deletions tests/Common/ThrowingTraceListener.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ public override void WriteLine(string message)
{
}

#if !NET8_0_OR_GREATER
[Serializable]
#endif
public class DebugAssertFailureException : Exception
{
public DebugAssertFailureException()
Expand All @@ -47,9 +49,11 @@ public DebugAssertFailureException(string message, Exception inner) : base(messa
{
}

#if !NET8_0_OR_GREATER
protected DebugAssertFailureException(SerializationInfo info, StreamingContext context) : base(info, context)
{
}
#endif
}
}
}

0 comments on commit fd6ac06

Please sign in to comment.