Add O# EA accessor for DocumentId.CreateFromSerialized #70229
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| { | ||
| internal static class OmniSharpDocumentId | ||
| { | ||
| public static DocumentId CreateFromSerialized(ProjectId projectId, Guid id, bool isSourceGenerated, string? debugName) |
There was a problem hiding this comment.
what's the use case where omnisharp needs to create a doc-id from a serialized form? How does it even get the value to pass into bool isSourceGenerated? we don't expose that property public on our doc-id in the first place. Thanks! :)
There was a problem hiding this comment.
The O# navigation service can return source generated file info as part of a GoToDefinition response (See omnisharp/omnisharp-roslyn/GoToDefinitionServiceV2.cs). When this navigation item is selected by the user the client will then request the document from the server and provide it to the editor (See dotnet/vscode-csharp/SourceGeneratedDocumentProvider.ts and omnisharp/omnisharp-roslyn/SourceGeneratedFileService). So,we are round tripping the DocumentId.
There was a problem hiding this comment.
i don't understand. you are undoing things to get the guid and pass that along. instead of doing that, why not actually send the DocID itself instead? i.e. instead of document.Id.Id, just send doument.Id.
There was a problem hiding this comment.
@CyrusNajmabadi I think the case here is similar to what we have for LSP: we can take the document ID as a GUID and send that over the wire, and when we get it back we know it's source generated based on the URI prefix or something similar.
ghost
added this to the 
This will replace reflection added in OmniSharp/omnisharp-roslyn#2567