VBOverloadResolutionPriority: break attribute binding cycles, clone a bunch of C# tests #76008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bunch of C# tests
dotnet-issue-labeler
bot
added
the
untriaged
333fred
approved these changes
Nov 21, 2024
|
@cston, @dotnet/roslyn-compiler For the second review |
1 similar comment
|
@cston, @dotnet/roslyn-compiler For the second review |
cston
reviewed
Nov 23, 2024
| throw DirectCast(Nothing, System.Exception) | ||
| End Sub | ||
| " | ||
|
|
There was a problem hiding this comment.
It looks like these are not used. #Resolved
There was a problem hiding this comment.
It looks like these are not used.
Looks this way. Will remove.
cston
reviewed
Nov 23, 2024
|
|
||
| Dim compilation = CreateCompilation({source, OverloadResolutionPriorityAttributeDefinitionVB}, options:=TestOptions.DebugExe) | ||
|
|
||
| ' Note, VB silently ignores attributes at wrong location |
There was a problem hiding this comment.
It looks like there is such a test already: Overrides_ChangePriorityInMetadata_Methods.
cston
reviewed
Nov 23, 2024
| " | ||
|
|
||
| Dim compilation = CreateCompilation(source, options:=TestOptions.DebugExe) | ||
| compilation.AssertTheseEmitDiagnostics( |
There was a problem hiding this comment.
Is that not useful here?
It is done below. The compilation is recreated after we check diagnostics
cston
approved these changes
Nov 23, 2024
AlekseyTs
merged commit 9e8ad61
into
dotnet:features/VBOverloadResolutionPriority
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.