[release/9.0] JIT: Avoid removing CSE candidates in fgMorphExpandCast #106746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
jeffschwMSFT
approved these changes
Aug 21, 2024
|
/ba-g failures are tracked but this is a release branch |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106691 to release/9.0
/cc @jakobbotsch
Customer Impact
With certain code patterns (such as in the regression test added to the PR), the JIT will fail to perform a CSE it expects to be able to perform. This will lead to failure to compile the method with optimizations and rejitting it with MinOpts instead.
Regression
Testing
Added regression test.
Risk
Low. Skips an optimization causing the problem in the certain case where it can't be done.