Move computation of DebuggerAssemblyControlFlags from DomainAssembly to Assembly
#107809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
jkotas
approved these changes
Sep 13, 2024
3 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 3, 2024
…to Assembly (dotnet#107809) This moves the initial computation into `Assembly` and removes the flags from `DomainAssembly`. Actual consumers were already getting the flags off of `Assembly` or `Module`
|
@elinor-fung, I tried cleaning up the DomainAssembly class #108568, I'm not sure about EnumMemoryRegions in Assembly vs. DomainAssembly (just used the one in assembly which has slightly different ordering), but rest was straightforward. After this, DomainAssembly has just one field left; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the initial computation into
Assemblyand removes the flags fromDomainAssembly. Actual consumers were already getting the flags off ofAssemblyorModulecc @jkotas @AaronRobinsonMSFT