Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Blocking Finalizer Thread During Shutdown in SystemEvents #108489

Merged
merged 21 commits into from
Nov 13, 2024
Merged

Avoid Blocking Finalizer Thread During Shutdown in SystemEvents #108489

merged 21 commits into from
Nov 13, 2024

Commits on Oct 7, 2024

  1. Add switch to enable legacy Thread.Join in SystemEvents.Shutdown and … 

    …obsolete EventsThreadShutdown
    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f15fdf2 View commit details
    Browse the repository at this point in the history

  2. code cleanup

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2434963 View commit details
    Browse the repository at this point in the history

  3. Add regression test

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    52fc6ed View commit details
    Browse the repository at this point in the history

  4. Call PostQuitMessage instead of PostMessage(WM_QUIT)

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    13d2c4f View commit details
    Browse the repository at this point in the history

  5. Remove compat switch and address PR feedback

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    dc8813c View commit details
    Browse the repository at this point in the history

  6. rebuild with /p:ApiCompatGenerateSuppressionFile=true

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7694fa7 View commit details
    Browse the repository at this point in the history

  7. Call PostQuitMessage on SystemEvents thread

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    13a6d37 View commit details
    Browse the repository at this point in the history

  8. Try removing left/right on compatbilitysuppression.xml

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    25a247b View commit details
    Browse the repository at this point in the history

  9. Obsolete EventsThreadShutdown

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    428aa3b View commit details
    Browse the repository at this point in the history

  10. Remove shutdown handling to make behavior deterministic

    @lonitra
    lonitra committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c4817f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Adjust obsolete message 

    Co-authored-by: Jan Kotas <[email protected]>
    @lonitra @jkotas
    lonitra and jkotas authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b11670e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Add obsoletion to refs

    @lonitra
    lonitra committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7ee2524 View commit details
    Browse the repository at this point in the history

  2. Set IncludeInternalObsoleteAttribute in ref project

    @lonitra
    lonitra committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4635420 View commit details
    Browse the repository at this point in the history

  3. re-include Obsoletions.cs in ref project

    @lonitra
    lonitra committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    134aca8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. revert 134aca8 and hardcode obsoletion

    @lonitra
    lonitra committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    aeb1008 View commit details
    Browse the repository at this point in the history

  2. Add IncludeInternalObsoleteAttribute to System.Events project

    @lonitra
    lonitra committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f70c8b6 View commit details
    Browse the repository at this point in the history

  3. remove Obsoletions.cs from compile include

    @lonitra
    lonitra committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    452146d View commit details
    Browse the repository at this point in the history

  4. Revert "remove Obsoletions.cs from compile include" 

    This reverts commit 452146d.
    @lonitra
    lonitra committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    787aa6a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge remote-tracking branch 'origin/main' into finalizerhang

    @ViktorHofer
    ViktorHofer committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ab4f074 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Update suppression file

    @ViktorHofer
    ViktorHofer committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5a28279 View commit details
    Browse the repository at this point in the history

  2. Update obsolete message 

    Co-authored-by: Stephen Toub <[email protected]>
    @lonitra @stephentoub
    lonitra and stephentoub authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    92f78ef View commit details
    Browse the repository at this point in the history