JIT: Disallow SCEV analysis of non-values #108603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCEV analysis would allow stores either via simple add-rec handling or by forwarding to the data of the store. Given that stores are not values this is odd behavior that has bitten me while consuming the analysis package. Switch the analysis to return nullptr for stores; instead add handling for `GT_PHI` in the places where it was needed.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Oct 7, 2024
|
/ba-g runtime-dev-innerloop is stuck, rest succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCEV analysis would allow stores either via simple add-rec handling or by forwarding to the data of the store. Given that stores are not values this is odd behavior that has bitten me while consuming the analysis package.
Switch the analysis to return nullptr for stores; instead add handling for
GT_PHIin the places where it was needed.