JIT: Fold (x + c1) + c2 in lowering
#108779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This transformation already exists in morph, but this duplicates the transformation in lowering to facilitate removing the call to morph from CSE. This transformation happening after CSE is somewhat important because shared constant CSE can introduce this IR shape.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
3 tasks
EgorBo
reviewed
Oct 11, 2024
| BlockRange().Remove(op1); | ||
| BlockRange().Remove(op2); | ||
| node->BashToConst(op1->AsIntCon()->IconValue() + op2->AsIntCon()->IconValue(), node->TypeGet()); | ||
| int64_t c1 = op1->gtGetOp2()->AsIntConCommon()->IntegralValue(); |
There was a problem hiding this comment.
You could probably save several lines of code to do gtFoldExprConst(gtNewOperNode(GT_ADD, op1->gtGetOp2(), op2)) instead
There was a problem hiding this comment.
Ah yeah, I'll keep that in mind for the future
EgorBo
reviewed
Oct 11, 2024
| if (comp->opts.OptimizationEnabled() && op1->IsCnsIntOrI() && op2->IsCnsIntOrI() && !node->gtOverflow() && | ||
| (op1->IsIconHandle(GTF_ICON_OBJ_HDL) || op2->IsIconHandle(GTF_ICON_OBJ_HDL)) && | ||
| !op1->AsIntCon()->ImmedValNeedsReloc(comp) && !op2->AsIntCon()->ImmedValNeedsReloc(comp)) | ||
| if (comp->opts.OptimizationEnabled()) |
There was a problem hiding this comment.
Could be relaxed to Tier0OptimizationEnabled
There was a problem hiding this comment.
Let me relax this in a separate PR since it will also enable the existing opt in tier 0
EgorBo
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transformation already exists in morph, but this duplicates the transformation in lowering to facilitate removing the call to morph from CSE. This transformation happening after CSE is somewhat important because shared constant CSE can introduce this IR shape.
This should address a number of regressions seen for arm64 in #106695.