Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] [wasm] Use correct current runtime pack version for Wasm.Build.Tests #109820

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 14, 2024

Wasm.Build.Tests are not a shipping project, PackageVersion will have a version suffix even for release branch, where actual runtime pack version doesn't have version suffix. Use ProductVersion in that case, based on StabilizePackageVersion value.

Should fix #109626
Should fix #108937
Should fix #108938
Should fix #109625

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Nov 14, 2024
@maraf maraf added this to the 9.0.x milestone Nov 14, 2024
@maraf maraf self-assigned this Nov 14, 2024
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@lewing lewing added the Servicing-approved Approved for servicing release label Nov 14, 2024
@lewing
Copy link
Member

lewing commented Nov 14, 2024

tell-mode test change

@maraf maraf merged commit 773fe75 into dotnet:release/9.0-staging Nov 14, 2024
26 of 32 checks passed
@maraf maraf deleted the WbtRuntimePackVersion branch November 14, 2024 17:33
@maraf maraf changed the title [wasm] Use correct current runtime pack version for Wasm.Build.Tests [release/9.0] [wasm] Use correct current runtime pack version for Wasm.Build.Tests Nov 14, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 9.0.x, 9.0.1 Dec 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants