Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reading custom attributes in NativeLibrary avoidable #80677

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Make reading custom attributes in NativeLibrary avoidable #80677

merged 1 commit into from
Jan 16, 2023

Commits on Jan 16, 2023

  1. Make reading custom attributes in NativeLibrary avoidable 

    Contributes to dotnet#80165.

Unfortunately, the `NativeLibrary` APIs contain a pattern where one can skip providing a parameter to the API and then something expensive (custom attribute reading) will happen to compute the value. We have a `TryLoad` call in a hello world that does provide the value (in GlobalizationMode.cs). Make it possible to avoid the expensive thing internally.
    @MichalStrehovsky
    MichalStrehovsky committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    3b5921c View commit details
    Browse the repository at this point in the history