-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: stop checking for dotnet cli version #44958
base: release/9.0.2xx
Are you sure you want to change the base?
Conversation
@dotnet/roslyn-ide for review |
@Cosifne @dotnet/roslyn-ide for review |
Might better to get a review from Joey as I am unfamiliar with the format codebase |
I am thinking that since dotnet-format is building out of the SDK repo. The dotnet CLI version and the dotnet-format version should be the "same", although it appears that the CLI's version truncates the specifics of the build number. We may just want to ditch logging the CLI version as it should be matched. |
Per offline discussion we think we just shouldn't do this check any more because we are shipping in the sdk anyway. @JoeRobich |
It looks like the macOS job has failed after 3 attempts. The only test results appear to be failing work items. The helix logs are very verbose and I'm having difficulty interpreting what is failing here. @ViktorHofer @MiYanni do you have any insight into what is failing in CI here? |
I took a brief look but no idea, sorry. Someone from the sdk team should be able to help. cc @joeloff |
@joeloff for assistance with #44958 (comment) |
This is just Helix timing out. We had a lot of failures on code flow PRs as well. We split some of the tests recently in main to decrease the load within a single run. |
I'm going to try and backport one of our changes in main to 9.0.2xx that split out the ILLink tests. |
dotnet/format#2218
@JoeRobich does this seem like a reasonable step to get more info about the issue?