-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style ToolTip to make it dark enough in Dark mode #12420
base: main
Are you sure you want to change the base?
Style ToolTip to make it dark enough in Dark mode #12420
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12420 +/- ##
===================================================
+ Coverage 75.64273% 75.70903% +0.06629%
===================================================
Files 3147 3153 +6
Lines 635806 635800 -6
Branches 47012 46982 -30
===================================================
+ Hits 480941 481358 +417
+ Misses 151423 151004 -419
+ Partials 3442 3438 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/src/System/Windows/Forms/ToolTip/ToolTip.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolTipTests.cs
Outdated
Show resolved
Hide resolved
Overall changes LGTM, @KlausLoeffelmann what do you think of the changes here? |
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolTipTests.cs
Outdated
Show resolved
Hide resolved
This will disable round corners see also treeview,listview,tabs and some other controls has internal tooltips need to be darked. |
src/System.Windows.Forms/tests/TestUtilities/ApplicationColorModeScope.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/TestUtilities/ApplicationColorModeScope.cs
Outdated
Show resolved
Hide resolved
Marking this PR as a draft as @memoarfaa has pointed out that it could be improved. I need to take a look at the @memoarfaa - Have you done work in this area already? |
@memoarfaa - Here's an example with your suggestions applied.
|
@memoarfaa Thank you for the heads up. I understand there are some other internal tooltips that will need to be darkened and I plan to help out with those when I can. I've implemented your suggestions here and have rounded the corners with a small radius. |
@memoarfaa Are you aware of any other tooltips that need to be darkened? |
The tooltips have been styled to be dark when dark mode is enabled, including the balloons, and the corners have been rounded for Windows 11 or greater. I need some guidance on how to unit test and verify the theme being used by the tooltip when the system is in dark mode. If someone could give me a nudge for the test, I would greatly appreciate it. This pull request is ready for review. |
Fixes #11954
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Microsoft Reviewers: Open in CodeFlow