Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Update dependencies from dotnet/arcade #12484

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[release/9.0] Update dependencies from dotnet/arcade #12484

merged 4 commits into from
Nov 25, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 14, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 92989bf7-cdf9-483d-64c5-08dcbc356d11
  • Build: 20241122.2
  • Date Produced: November 22, 2024 6:31:15 PM UTC
  • Commit: b41381d5cd633471265e9cd72e933a7048e03062
  • Branch: refs/heads/release/9.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 9.0.100
    • Updates tools.dotnet to 9.0.100
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner November 14, 2024 14:42
dotnet-policy-service[bot]
dotnet-policy-service bot previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@lonitra lonitra force-pushed the darc-release/9.0-c478adb8-3d50-4652-b08f-22a9ad83c82f branch from 43096e6 to ef7cbbd Compare November 14, 2024 19:08
@lonitra
Copy link
Member

lonitra commented Nov 14, 2024

Resolved merge conflicts

@lonitra
Copy link
Member

lonitra commented Nov 19, 2024

Error:

pkg\Microsoft.Dotnet.WinForms.ProjectTemplates\Microsoft.Dotnet.Winforms.ProjectTemplates.csproj(0,0): error NU1103: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find a stable package Microsoft.TemplateEngine.Authoring.Tasks with version (>= 9.0.101)

@mmitche Do you have any pointers on how to resolve errors? I had tried adding the same key as in https://github.com/dotnet/winforms/pull/12484/files, but realize it seems like it's not needed since the arcade sdk seems to get updated correctly here.

@dotnet-maestro @lonitra
Update dependencies from https://github.com/dotnet/arcade build 20241…
ff4315f 
…112.13

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24516.2 -> To Version 9.0.0-beta.24562.13
@lonitra lonitra force-pushed the darc-release/9.0-c478adb8-3d50-4652-b08f-22a9ad83c82f branch from ef7cbbd to ff4315f Compare November 19, 2024 19:40
@lonitra
Copy link
Member

lonitra commented Nov 22, 2024

@dotnet/templating-engine-maintainers It looks like there might be a transitive dependency on unstable package version in Microsoft.TemplateEngine.Authoring.Tasks. Can you advise on how to resolve this? This looks similar to dotnet/sdk#36659

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
74c1a3a 
…122.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24503.2 -> To Version 9.0.0-beta.24572.2
@mmitche
Copy link
Member

mmitche commented Nov 25, 2024

@lonitra The templating dependency update should be gone now. I downgraded it to 9.0.100. Looks like language changes now.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83200%. Comparing base (f9ea016) to head (1995961).
Report is 1 commits behind head on release/9.0.

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           release/9.0      #12484          +/-   ##
======================================================
- Coverage     97.00790%   74.83200%   -22.17591%     
======================================================
  Files             1066        3022        +1956     
  Lines           345811      630201      +284390     
  Branches          5038       46791       +41753     
======================================================
+ Hits            335464      471592      +136128     
- Misses            9625      155226      +145601     
- Partials           722        3383        +2661
Flag Coverage Δ
Debug 74.83200% <100.00000%> (-22.17591%) ⬇️
integration 18.02909% <ø> (?)
production 47.86666% <ø> (?)
test 97.00790% <100.00000%> (ø)
unit 44.89504% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit 95405cd into release/9.0 Nov 25, 2024
8 checks passed
@lonitra lonitra deleted the darc-release/9.0-c478adb8-3d50-4652-b08f-22a9ad83c82f branch November 25, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonitra lonitra lonitra approved these changes

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonitra @mmitche