-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xharness should also download/install the versions of the simulators #478
Labels
apple
iOS/tvOS/WatchOS/Mac Catalyst area
emulator
Related to an emulator/Simulator
enhancement
New feature or request
Comments
There is some code for this in this repo already which is packaged into another .NET tool and can do this:
This tool is actually originally coming from the siminstaller you've linked, just it was re-written. We could easily move these commands into XHarness CLI itself. @tkapin thoughts? |
premun
added a commit
that referenced
this issue
Mar 8, 2021
This removes the SimulatorInstaller project and moves the file to CLI so that you can do: ``` xharness apple simulators list ``` When installing the simulators, it doesn't accept the same format e.g. `ios-simulator-64` of targets as the CLI, this will be a follow-up. #478
premun
added a commit
that referenced
this issue
Mar 17, 2021
* Add triggers for xcode/* branches (#450) * Remove dead code around TestRunner argument passing (#449) - I compared what we send to and what we receive from the TestRunner EntryPoint and noticed quite a bit of unused options. These are remnants of the Xamarin code with which we don't share the EntryPoint anymore - We are passing arguments both via env variables and arguments so we will only pass the env vars now - There was a bug in the definition of the `class` argument and it wasn't parsed properly - Another thing I fixed are the "extra" arguments - I don't they they were working until know because we prepend them with a `-app-arg:` prefix which is only recognized in the Xamarin's mono Main * Improve various logging (#463) Side effects of other work, related to #358 * Fail faster when cannot find any devices/emulators (#469) * fail faster when cannot find any devices/emulators * Apply suggestions from code review Co-authored-by: Přemek Vysoký <[email protected]> Co-authored-by: Přemek Vysoký <[email protected]> * Move to new location of netcorenativeassets (#471) * Remove the DummyTestProject (#472) * Add support for the MacCatalyst target (#464) - Adds support for the `apple test -t=maccatalyst` command (resolves #435) - Getting system logs for the process is not working at the moment (#459) - The `apple run` command cannot detect exit code yet (#462) * Capture System.log when running MacCatalyst apps (#474) Resolves #459 * Make sure the MacCatalyst app's binary is executable (#475) * Allow to skip device-id for android install/run/uninstall (#479) * allow to skip device-id for android install/run/uninstall if device can be choosed unambiguously * Update src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs Co-authored-by: Přemek Vysoký <[email protected]> * addressed review feedback Co-authored-by: Přemek Vysoký <[email protected]> * Update dependencies from https://github.com/dotnet/arcade build 20210225.5 (#482) [main] Update dependencies from dotnet/arcade * Run MacCatalyst via `open w` and detect exit code from logs (#484) Resolves #462 * Add integration tests for MacCatalyst (#487) * Add integration tests for the MacCatalyst target * Make Helix tests run on local * Remove EnableXUnitReporter * Create template proj for integration tests * Display the name of the exit code (#488) * Wait for MacCatalyst system.log flush (#490) * Don't reset the stream if we got a partial message (#489) Fixes #473 * Do not report LaunchFailure when the app connected over TCP (#491) * [wasm] add `--expected-exit-code` for `wasm test-browser`, similar to (#492) .. what `wasm test` has. * Rename iOS namespace to Apple (#494) * Merge SimulatorInstaller commands to main CLI (#497) This removes the SimulatorInstaller project and moves the file to CLI so that you can do: ``` xharness apple simulators list ``` When installing the simulators, it doesn't accept the same format e.g. `ios-simulator-64` of targets as the CLI, this will be a follow-up. #478 * [wasm] Ensure that Safari/firefox drivers are Disposed in case of (#500) .. failures. This manifested when running with Safari, and it doesn't have `remote automation` enabled. That would cause xharness to get stuck because of the still running driver process. ``` crit: System.InvalidOperationException: Could not create a session: You must enable the 'Allow Remote Automation' option in Safari's Develop menu to control Safari via WebDriver. (SessionNotCreated) at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response errorResponse) at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters) at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredCapabilities) at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecutor, ICapabilities desiredCapabilities) at OpenQA.Selenium.Safari.SafariDriver..ctor(SafariDriverService service, SafariOptions options, TimeSpan commandTimeout) at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.GetSafariDriver(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 98 at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 63 at Microsoft.DotNet.XHarness.Common.CLI.Commands.XHarnessCommand.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.Common/CLI/Commands/XHarnessCommand.cs:line 120 XHarness exit code: 71 (GENERAL_FAILURE) XHarness artifacts: ./xharness-output ``` * [wasm][test-browser] Add `--browser-path` to use custom browser paths (#501) * Detect old version of MacOS in MacCatalyst test runs (#495) * Add base entry point class for android tests (#454) * add base instrumentation class for android tests * Update src/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit.csproj Co-authored-by: Přemek Vysoký <[email protected]> * review feedback * Update src/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit/AndroidInstrumentationBase.cs Co-authored-by: Manuel de la Pena <[email protected]> * addressed review feedback * remove instrumentation part, leave only default test entry point for android * address review feedback * remove test project Co-authored-by: Přemek Vysoký <[email protected]> Co-authored-by: Manuel de la Pena <[email protected]> * Fix CLI behavior when doing `xharness` or `xharness help` (#504) * [main] Update dependencies from dotnet/arcade (#499) [main] Update dependencies from dotnet/arcade - Merge remote-tracking branch 'origin/main' into darc-main-37ceeb7c-81af-4535-a6eb-96fcd2db6c28 - Merge remote-tracking branch 'origin/main' into darc-main-37ceeb7c-81af-4535-a6eb-96fcd2db6c28 - Update unit tests project to net6.0 * Fix possible merge mistake. * Revert performance-setup.sh Co-authored-by: Přemek Vysoký <[email protected]> Co-authored-by: Katya Sokolova <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
premun
added a commit
that referenced
this issue
Mar 24, 2021
XHarness simulators command now also accepts target runtimes in the same format as test targets. These formats are now equivalent: - `com.apple.pkg.iPhoneSimulatorSDK14_3` - `ios-simulator_14.3` There is also a breaking change for the `install` and `find` commands - we now accept the list of simulators as positional arguments instead of `--simulator` arguments. The new usage is this: ``` xharness apple simulators install ios-simulator_14.3 tvos-simulator_11.6 ``` Resolves #478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apple
iOS/tvOS/WatchOS/Mac Catalyst area
emulator
Related to an emulator/Simulator
enhancement
New feature or request
It would be nice if there was a way to install simulators for iOS as all the info to the URL is there:
https://github.com/xamarin/xamarin-macios/tree/main/tools/siminstaller
I would maybe do something like:
When doing this for Android, it sort of fits in with #380 and #393 but this just calls upon the sdkmanager to also download.
The text was updated successfully, but these errors were encountered: