Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept test targets when working with the simulators command #517

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

premun
Copy link
Member

@premun premun commented Mar 23, 2021

XHarness simulators command now also accepts target runtimes in the same format as test targets. These formats are now equivalent:

  • com.apple.pkg.iPhoneSimulatorSDK14_3
  • ios-simulator_14.3

There is also a breaking change for the install and find commands - we now accept the list of simulators as positional arguments instead of --simulator arguments. The new usage is this:

xharness apple simulators install ios-simulator_14.3 tvos-simulator_11.6

Resolves #478

@premun
Copy link
Member Author

premun commented Mar 23, 2021

/cc @mattleibow

@mattleibow
Copy link
Member

The other commands also allowed for the bit size, so not sure if that is relevant or needs consistency :

ios-simulator-64_14.3

This might be relevant for watch things since I am not sure if any other architectures exist other than 64

@premun
Copy link
Member Author

premun commented Mar 23, 2021

@mattleibow it doesn't matter for the package names, I think you just need to install old enough version that are 32-bit if I am not mistaken.

However, I also allowed to enter ios-simulator-64 and -32 so that you can have it easy in the build and call both commands with the same target:

xharness apple simulators install ios-simulator-64_14.2
xharness apple test --target=ios-simulator-64_14.2 ...

@premun premun requested a review from mandel-macaque March 23, 2021 12:51
@premun premun merged commit 25dcd4a into dotnet:main Mar 24, 2021
@premun premun deleted the prvysoky/simulators branch March 24, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xharness should also download/install the versions of the simulators
3 participants