Do 346 writing spdx statements repeatedly #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autocomplete doesn't seem to natively work with textareas in browsers, so this commit changes the pattern field of a path exclusion form to a text input field. This allows the browser to remember the pattern history, improving the user experience. Signed-off-by: Etsija <[email protected]>
This commit adds a history to the SPDX Expression input field, by adding a "name" attribute to the input field. When the user starts typing, the input field will show a dropdown with the previously entered SPDX Expressions. Signed-off-by: Etsija <[email protected]>
Etsija
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Etsija
temporarily deployed
to
unittest-environment
GitHub Actions
Inactive
lamppu
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a "fast fix" to the issue for not remembering the SPDX Expressions which the user has input earlier to the license conclusions form. It utilizes the browser's native autosuggestion feature. Note that as of today, only Firefox seems to remember more than one earlier input, while Microsoft Edge and Chrome seem to have an autosuggestion history of exactly one element.