fix: add saml signout URL

doubtfire-lms · Jan 17, 2022 · 26e737b · 26e737b
1 parent aabea8f
commit 26e737b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/api/authentication_api.rb b/app/api/authentication_api.rb
@@ -282,8 +282,8 @@ class AuthenticationApi < Grape::API
     response[:auth_signout_url] =
       if aaf_auth? && Doubtfire::Application.config.aaf[:auth_signout_url].present?
         Doubtfire::Application.config.aaf[:auth_signout_url]
-      elsif saml_auth? && Doubtfire::Application.config.saml[:idp_sso_target_url].present?
-        Doubtfire::Application.config.saml[:idp_sso_target_url]
+      elsif saml_auth? && Doubtfire::Application.config.saml[:idp_sso_signout_url].present?
+        Doubtfire::Application.config.saml[:idp_sso_signout_url]
       end
     present response, with: Grape::Presenters::Presenter
   end

diff --git a/config/application.rb b/config/application.rb
@@ -59,6 +59,8 @@ class Application < Rails::Application
       config.saml[:entity_id] = ENV['DF_SAML_SP_ENTITY_ID']
       # The IDP SAML login URL, (e.g., "https://login.microsoftonline.com/xxxx/saml2")
       config.saml[:idp_sso_target_url] = ENV['DF_SAML_IDP_TARGET_URL']
+      # The IDP SAML logout URL, (e.g., "https://login.microsoftonline.com/xxxx/saml2")
+      config.saml[:idp_sso_signout_url] = ENV['DF_SAML_IDP_SIGNOUT_URL']
 
       # The SAML response certificate and name format (if no XML URL metadata is provided)
       if config.saml[:SAML_metadata_url].nil?
@@ -79,6 +81,7 @@ class Application < Rails::Application
         "  key                          => variable set?\n"\
         "  DF_SAML_CONSUMER_SERVICE_URL            => #{!ENV['DF_SAML_CONSUMER_SERVICE_URL'].nil?}\n"\
         "  DF_SAML_SP_ENTITY_ID          => #{!ENV['DF_SAML_SP_ENTITY_ID'].nil?}\n"\
+        "  DF_SAML_IDP_SIGNOUT_URL         => #{!ENV['DF_SAML_IDP_SIGNOUT_URL'].nil?}\n"\
         "  DF_SAML_IDP_TARGET_URL          => #{!ENV['DF_SAML_IDP_TARGET_URL'].nil?}\n"
       end