enhance: reject encrypted pdf #436

ublefo · 2024-04-11T02:43:14Z

Changes

Introduced the pdf-reader gem for proper PDF validation, which is a much more elegant solution than looking for strings from the binary file.
Added a unit test with some test files to test the changes, along with three test PDF files. The password for the encrypted file is password.
Refactored accept_file and PDF validation methods in FileHelper in order to return validation errors to the frontend.

password for the encrypted pdf test file is 'password'

maddernd · 2024-04-15T08:46:33Z

This one was approved.

maddernd · 2024-04-15T08:46:46Z

ublefo added 4 commits April 11, 2024 12:41

feat: add the pdf-reader gem for validating pdf submissions

71c845b

feat: improve pdf file validation and detect encrypted pdfs

dd729cf

feat: implement unit test for pdf validation on submit

57db1dc

password for the encrypted pdf test file is 'password'

enhance: refactor file submission validation and pass errors to frontend

a042df5

ublefo mentioned this pull request Apr 11, 2024

fix: reject encrypted PDF on upload thoth-tech/doubtfire-api#21

Closed

2 tasks

ublefo changed the title ~~Reject encrypted pdf~~ enhance: reject encrypted pdf Apr 16, 2024

macite approved these changes Apr 27, 2024

View reviewed changes

macite merged commit 18cc875 into doubtfire-lms:development Apr 27, 2024
4 checks passed

ublefo deleted the feat/reject-encrypted-pdf branch April 27, 2024 14:41

ublefo restored the feat/reject-encrypted-pdf branch April 27, 2024 15:00

ublefo deleted the feat/reject-encrypted-pdf branch May 2, 2024 16:32