fix: task file import #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ublefo
force-pushed
the
fix/task-file-import
branch
from
e01ee4a to
9fe418c
Compare
macite
requested changes
Apr 27, 2024
ublefo
force-pushed
the
fix/task-file-import
branch
from
9fe418c to
01454be
Compare
ublefo
force-pushed
the
fix/task-file-import
branch
from
01454be to
c44b147
Compare
macite
pushed a commit
to macite/doubtfire-api
that referenced
this pull request
Jun 1, 2024
* fix: sort taskdef by abbr length to ensure the longest match * fix: add a new task to test task files import filename matching * enhance: validate task sheet content in unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes task file import bug where a task file import will attach the task sheets and resources to the wrong task. Now we use the longest match to ensure the task file is imported to the correct task.
A new task
T10has been added to test this behavior, and now the unit test will validate the content of the task sheets forT1andT10so we can catch this in the future.