add factory pattern SimpleAtomicLongMultithreadedTest

[busylee999]

Create Runnnable intarfaces for RunTest class using factory pattern

[agonzalez8]

I think It's not the better way IMHO, check it please http://www.oodesign.com/factory-pattern.html

[busylee999]

Can you explain me your position. I have read text at this link. But I do not see any problems in this implementation.

[agonzalez8]

I refer to this part "... This implementation is the most simple and intuitive (Let's call it noob implementation). The problem here is that once we add a new concrete product [Runnable] call we should modify the Factory class. It is not very flexible and it violates open close principle. Of course we can subclass the factory class, but let's not forget that the factory class is usually used as a singleton. Subclassing it means replacing all the factory class references everywhere through the code..."

To make my point clear:

1. It would be more difficult add new tests, I would need to add a new enum , a case and a runnable implementation and call it, two steps more.
2. I don't see any benefit.

[busylee999]

I told in the discussions forum for mr. Douglas that may be in this case factory pattern is excess. And I just send pull request. Because I really think that it is more clearly and elegant solution than to have several static variables contains Runnable implementation.
What will you do if you will need to add more 10 test runnable implementations? You will add more 10 static variables. I think more flexible to store all implementation in one special place. And it will be easy to extract this class in own class file if it will be huge. It's about benefit.

About 1st point. Consider you want to add new test in realization with static vars. You still need to add new static var. Do you think it is really easier than add new enum item?