Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up OIE O2O Cookie Handling #147

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Clean up OIE O2O Cookie Handling #147

merged 3 commits into from
Dec 19, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Dec 1, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti changed the title ## Description <!--- Describe your changes in detail --> Clean up OIE O2O Cookie Handling Dec 1, 2023
@pcmxgti pcmxgti closed this Dec 18, 2023
@pcmxgti pcmxgti force-pushed the fix/cleanup_authz_cookies branch from 0f3a343 to dcc4b6a Compare December 18, 2023 19:13
@pcmxgti pcmxgti reopened this Dec 18, 2023
@pcmxgti pcmxgti marked this pull request as ready for review December 18, 2023 19:24
@pcmxgti
Copy link
Contributor Author

pcmxgti commented Dec 19, 2023

@sevignyj - this is rebased and ready for review

sevignyj
sevignyj approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@sevignyj sevignyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@sevignyj sevignyj merged commit 47cf2be into main Dec 19, 2023
23 checks passed
@pcmxgti pcmxgti deleted the fix/cleanup_authz_cookies branch December 19, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevignyj sevignyj sevignyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmxgti @sevignyj