Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Step-Up challenge assertion is too narrow. #150

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix: Step-Up challenge assertion is too narrow. #150

merged 1 commit into from
Dec 19, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Dec 7, 2023

Description

Change the check for a step-up challenge, so that it includes more test cases.

Also includes misc data debugging fixes.

Motivation and Context

Step-up Challenges were failing in some cases

How Has This Been Tested?

tox and development Okta instances

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti force-pushed the fix/stepup branch 2 times, most recently from b8654aa to 099cf04 Compare December 7, 2023 16:16
@pcmxgti pcmxgti marked this pull request as ready for review December 18, 2023 19:34
@pcmxgti
Copy link
Contributor Author

pcmxgti commented Dec 19, 2023

@sevignyj - this is rebased and ready for review

@pcmxgti pcmxgti merged commit 5b46a18 into main Dec 19, 2023
23 checks passed
@pcmxgti pcmxgti deleted the fix/stepup branch December 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants