Add UuidManagement and Callable #1
Conversation
Plus some manual removals
This originally used `present?` instead of `&.empty?`
find spec -name '*_spec.rb' -exec bundle exec rspec {} \;
| # include TrackBallast::UuidManagement | ||
| # end | ||
| # | ||
| module UuidManagement |
There was a problem hiding this comment.
What this is expected to look like on https://www.rubydoc.info/
benjaminoakes
deleted the
benjaminoakes/add-uuid-management-and-callable
branch
| require "track_ballast/version" | ||
|
|
||
| module TrackBallast | ||
| class Error < StandardError; end |
There was a problem hiding this comment.
Would be nice to start with a logger as well.
There was a problem hiding this comment.
I think you meant to use the lib/track_ballast/error.rb class?
There was a problem hiding this comment.
I think you meant to use the
lib/track_ballast/error.rbclass?
You're right, I did! Will follow up on that
| # This will short-circuit to be `@logger` on future runs | ||
| @logger = Rails.logger | ||
| else | ||
| raise NoLoggerError, "TrackBallast.logger is not configured" |
There was a problem hiding this comment.
Consider making this logger core to the TrackBallast module instead of raising here.
There was a problem hiding this comment.
Ah, this is perhaps something that could stand to be clarified in the README.
This method will raise because the TrackBallast.logger method could not locate a suitable logger to use. Typically, it will default to Rails.logger, but it could also be whatever the client of this gem decides is best. (For example, the client application could choose to route all TrackBallast logs elsewhere.) My thinking is that it's not appropriate to completely set up a logger within this library because we don't know the circumstances in which the code is run (besides running tests, of course).
Hopefully I'm understanding your comments correctly. 😄 If I'm not, let's circle up on DMs to discuss.
Starting
TrackBallastwith two commonly used modules:UuidManagementandCallableThe intention is to start using these versions internally. All commits have been crafted with the intention of being made public, open source code.