SDPA-5681: Accessibility for links which open in new tab. #1071
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudrasamey
force-pushed
the
feature/SDPA-5681-new-tab-button-accessibility
branch
from
b536f91 to
2fc7459
Compare
elNico
previously approved these changes
Oct 20, 2021
dylankelly
requested changes
Oct 20, 2021
There was a problem hiding this comment.
hi @mudrasamey - see review comments, dont need the extra prop, but adding the opens in a new window feature is appreciated!
dylankelly
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
WHEN a page contains a button that will take the user to a new tab
THEN the feature is WCAG 2.1 AA compliant and the user hears a title similar to "[Button text] - opens in new tab.
JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-5681
Changed
Screenshots