Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Improvement of documentation of class "DQ_Kinematics" #60

Open
ffasilva opened this issue Jun 26, 2020 · 1 comment
Open

[REQUEST] Improvement of documentation of class "DQ_Kinematics" #60

ffasilva opened this issue Jun 26, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request low priority question Further information is requested

Comments

@ffasilva
Copy link
Member

I have recently had a hard time trying to understand the function of the parameters reference_frame and base_frame of the class DQ_Kinematics. I am not sure if the problem is the current state of the documentation, the name of those parameters, or if I unnecessarily complicated things by looking at the code and thinking about how I would have done things instead of following the implementation (or even more likely, a combination of all above). Regardless, the impression I had is that "reference_frame" would set the frame of reference used by methods such as fkm, whereas base_frame would inform those methods of the current pose of the robot base.

Considering that, I was expecting the following results from the code:

  • After setting the robot's reference_frame to coincide with the pose of its end-effector, I expected a subsequent call of the method fkm to return DQ(1) since the transformation from the new reference frame to the end-effector is the identity;

  • After changing the base_frame, I expected to have a new end-effector pose returned by fkm since now the robot moved, and the reference frame remained unchanged.

I have spoken with @bvadorno, and he clarified things for me. Nonetheless, he asked me to open a request for documentation improvement. Unfortunately, as I am not sure of what exactly caused my confusion, I cannot recommend a specific solution.

@ffasilva ffasilva added the bug Something isn't working label Jun 26, 2020
@bvadorno bvadorno self-assigned this Jul 5, 2020
@bvadorno bvadorno added enhancement New feature or request question Further information is requested low priority and removed bug Something isn't working labels Jul 5, 2020
@bvadorno
Copy link
Member

bvadorno commented Jul 5, 2020

Hi, @frederico-afonso,

Thanks a lot for your comment. I assigned the issue to my self. I also changed the label to enhancement and question as the issue you mentioned is likely a documentation improvement instead of a bug.

Cheers,
Bruno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants