fixed weather app showing "Location Unavailable" #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My work environment blocks outgoing ping so the weather applet has never worked. I've changed the weather script to use Linux's tcp stackt to test connection to port 443 of ipinfo.io instead of pings.
|
Okay, I like this. It makes sense. I never considered a situation like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My work environment blocks outgoing ping so the weather applet has never worked.
I've changed the weather script to use Linux's TCP stack to test connection to port 443 of ipinfo.io instead of pings.
I also added a space for formatting the Unicode symbol and the temperature as on my system they were overlapping, I am happy to revert that change if requested.