[pull] trunk from WordPress:trunk #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This commit fixes a regression whereby requests to global styles endpoints were not being preloaded, resulting in several requests being fired clientside unnecessarily. For performance reasons, we preload the requests so that the data is in the editor store and ready to use straight away. The outcome is that the editor loads more quickly. Follow-up to [62042]. Props ellatrix, ramonopoly, apermo, peterwilsoncc. Fixes #62315. git-svn-id: https://develop.svn.wordpress.org/trunk@59316 602fd350-edb4-49c9-b593-d223f7449a82
…g regardless of dimensions. Props ironprogrammer, adamsilverstein, azaozz. Fixes #62305. git-svn-id: https://develop.svn.wordpress.org/trunk@59317 602fd350-edb4-49c9-b593-d223f7449a82
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag. Props kevin940726, aaronrobertshaw. See #62309. git-svn-id: https://develop.svn.wordpress.org/trunk@59318 602fd350-edb4-49c9-b593-d223f7449a82
…mment data. The previous approach of running `wp_allow_comment()` twice could have unintended consequences, e.g. the `check_comment_flood` action was also triggered twice, which might lead to false-positive identification of comment flood in case there is some custom callback hooked to it, which is not expecting identical data seeing twice. This commit introduces a new function, `wp_check_comment_data()`, to specifically check for disallowed content before and after comment data is filtered. Follow-up to [59267]. Props david.binda, SergeyBiryukov. See #61827. git-svn-id: https://develop.svn.wordpress.org/trunk@59319 602fd350-edb4-49c9-b593-d223f7449a82
Remove further documentation and a code reference to the unsupported `count` argument within `WP_Term_Query`. Follow up to [59261]. Props johnbillion. Fixes #61094 git-svn-id: https://develop.svn.wordpress.org/trunk@59325 602fd350-edb4-49c9-b593-d223f7449a82
Reverts an earlier change to the test suite in which the PHPUnit tests could not run if the importer plugin was not available. This update allows the test suite to run and will fail importer tests if the plugin is not available. Follow up to r59085. Props peterwilsoncc, azaozz. See #62325. git-svn-id: https://develop.svn.wordpress.org/trunk@59326 602fd350-edb4-49c9-b593-d223f7449a82
….php`. Follow-up to [52049], [54118], [54162], [55008], [55349], [55959], [55986], [56058], [57496], [58354], [58413]. Props mukesh27, ramonopoly. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59328 602fd350-edb4-49c9-b593-d223f7449a82
Updates the images in the About page source with the final versions on the w.org CDN. Props ryelle, joen. See #61961. git-svn-id: https://develop.svn.wordpress.org/trunk@59329 602fd350-edb4-49c9-b593-d223f7449a82
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag. Props kevin940726, ramonopoly, andrewserong. git-svn-id: https://develop.svn.wordpress.org/trunk@59330 602fd350-edb4-49c9-b593-d223f7449a82
…meter name. Follow-up to [54927]. Props justlevine. See #52217, #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59333 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [48033]. Props justlevine. See #52217, #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59334 602fd350-edb4-49c9-b593-d223f7449a82
This commit fixes an omission in the logic of `WP_Theme_JSON::merge()` where top-level background image style objects are not replaced, rather they are merged. Because background images are self contained objects, their properties are unique and should not be merged. Blocks are already catered for via `WP_Theme_JSON::get_block_nodes()`. Follow-up to [61858]. Props ramonopoly, andrewserong. Fixes #62328. git-svn-id: https://develop.svn.wordpress.org/trunk@59335 602fd350-edb4-49c9-b593-d223f7449a82
This commit adds missing `void` return types to (parent) methods that can ''explicitly'' return `void` as one of their conditional paths. Addressed methods: * `WP_Privacy_Requests_Table::column_status()` * `WP_Recovery_Mode::handle_error()` * `WP_Widget::form()` — unlike the others, it's the ''child'' classes that return `void` when the method is correctly implemented. Note: `@return void` (where `void` is the single type returned) should not be used outside the default bundled themes and the PHP compatibility shims included in WordPress Core, as per the [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/ documentation standards]. Follow-up to [30382], [42967], [43256], [44973], [45448]. Props justlevine. See #52217, #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59336 602fd350-edb4-49c9-b593-d223f7449a82
…ods. This commit fixes an issue where some magic `__isset()` methods were potentially returning `void` (if the prop is not in an allow-listed array of fields) instead of an explicit boolean `false`. Addressed methods: * `WP_Comment::__isset()` * `WP_Query::__isset()` Follow-up to [28523], [31151], [34583], [34599]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59337 602fd350-edb4-49c9-b593-d223f7449a82
This commit affects `WP_Theme_JSON_Resolver::resolve_theme_file_uris()`. When setting resolved URIs in an incoming theme json object, this commit removes the unnecessary call to `WP_Theme_JSON->merge()`. Why? `WP_Theme_JSON_Resolver::resolve_theme_file_uris()` only needs to set values for paths in the raw theme json object. It can then return a new theme object based on the updated JSON source. There's no need for a full and possibly expensive merge. Follow-up to [61588]. Props ramonopoly, aaronrobertshaw, andrewserong. Fixes #62329. git-svn-id: https://develop.svn.wordpress.org/trunk@59338 602fd350-edb4-49c9-b593-d223f7449a82
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag. Props kevin940726, get_dave. Close #62321. git-svn-id: https://develop.svn.wordpress.org/trunk@59339 602fd350-edb4-49c9-b593-d223f7449a82
…s::test_*()`. This commit corrects several instances of `test_*()` methods potentially returning `void` instead of their documented return types. Since these methods are public, `null` is used to represent a passed test for backward compatibility with the coercion of the previously-returned `void`. Previous usage of `false` is preserved. Includes updating some `@return` tags for clarity. Follow-up to [44986], [46276], [49927]. Props justlevine, apermo, SergeyBiryukov. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59340 602fd350-edb4-49c9-b593-d223f7449a82
…get_etag()`. This fixes an issue with the usage of the new `$wp_styles->get_etag()` method in `wp-admin/load-styles.php`, where `$wp_version` is passed as the first argument instead of `$load` being used as the ''only'' argument. Follow-up to [58935]. Props justlevine, mukesh27, swissspidy. See #52217, #61485. git-svn-id: https://develop.svn.wordpress.org/trunk@59341 602fd350-edb4-49c9-b593-d223f7449a82
This updates the version of each default theme to the following versions: * Twenty Ten: 4.3 * Twenty Eleven: 4.8 * Twenty Twelve: 4.4 * Twenty Thirteen: 4.3 * Twenty Fourteen: 4.1 * Twenty Fifteen: 3.9 * Twenty Sixteen: 3.4 * Twenty Seventeen: 3.8 * Twenty Nineteen: 3.0 * Twenty Twenty: 2.8 * Twenty Twenty-One: 2.4 * Twenty Twenty-Two: 1.9 * Twenty Twenty-Three: 1.6 * Twenty Twenty-Four: 1.3 These versions will released in coordination with WordPress 6.7. Props sh4lin, sabernhardt, mukesh27, chaion07. Fixes #62034. git-svn-id: https://develop.svn.wordpress.org/trunk@59344 602fd350-edb4-49c9-b593-d223f7449a82
…mage_editor_output_format()`. Props peterwilsoncc, apermo, azaozz. See #62305. git-svn-id: https://develop.svn.wordpress.org/trunk@59346 602fd350-edb4-49c9-b593-d223f7449a82
Syncs @wordpress/* packages to the wp-6.7 npm tag. Props kevin940726, get_dave, youknowriad Close #62321. git-svn-id: https://develop.svn.wordpress.org/trunk@59347 602fd350-edb4-49c9-b593-d223f7449a82
This merges the latest improvements to the Twenty Twenty-Five theme from GitHub into WordPress-Develop for 6.7 RC 3. A full list of changes can be found on GitHub: WordPress/twentytwentyfive@b6f4ee2...b5b0475. Props juanfra. See #62343. git-svn-id: https://develop.svn.wordpress.org/trunk@59348 602fd350-edb4-49c9-b593-d223f7449a82
This updates the following GitHub Actions to their latest versions: - `wow-actions/welcome` - `actions/setup-node` - `actions/cache` See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59354 602fd350-edb4-49c9-b593-d223f7449a82
[59287] updated the test coverage workflow to make use of the reusable PHPUnit workflow logic to prevent having duplicate code. The workflow should be run when the reusable file is updated to confirm any changes made work as expected. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59355 602fd350-edb4-49c9-b593-d223f7449a82
This adds documentation for how to generate code coverage reports to the README.md file. `test:coverage` has also been added as an npm script to make it easier to generate a report using the local Docker environment. The script will generate an HTML, PHP, and text report file. Props pbearne, hellofromTonya, netweb. Fixes #53414. git-svn-id: https://develop.svn.wordpress.org/trunk@59356 602fd350-edb4-49c9-b593-d223f7449a82
…vate property. This resolves an issue where the private property `WP_User_Query::$results` is accessed directly in `WP_REST_Users_Controller::get_items()` instead of via the `::get_results()` method. Follow-up to [38832]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59357 602fd350-edb4-49c9-b593-d223f7449a82
Props peterwilsoncc. See #62272. git-svn-id: https://develop.svn.wordpress.org/trunk@59358 602fd350-edb4-49c9-b593-d223f7449a82
…style_variations()` In `WP_Theme_JSON::get_valid_block_style_variations()`, the method was calling `self::get_blocks_metadata()` even though the metadata was already retrieved in the parent function. This update reuses the existing block metadata instead of calling it again. A new optional parameter, `$blocks_metadata`, has been added to the function, allowing it to use pre-fetched metadata when available, improving efficiency. Fewer `self::get_blocks_metadata()` calls mean faster processing, especially in themes with many blocks. Props mukesh27, ramonopoly, aaronrobertshaw, flixos90. Fixes #62291. git-svn-id: https://develop.svn.wordpress.org/trunk@59359 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [4612], [21967], [24490], [47611], [48214]. Props arnoutblueshell, karthickmurugan, SergeyBiryukov. Fixes #62803. git-svn-id: https://develop.svn.wordpress.org/trunk@59602 602fd350-edb4-49c9-b593-d223f7449a82
See #62005 git-svn-id: https://develop.svn.wordpress.org/trunk@59603 602fd350-edb4-49c9-b593-d223f7449a82
…oad_url()` tests. This aims to avoid affecting other tests in case of failure. Follow-up to [42773], [51939]. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59604 602fd350-edb4-49c9-b593-d223f7449a82
…emplate parts. Fixes those endpoints for file-based templates and template parts, as templates based on theme files can't be revisioned or autosaved. Props antonvlasenko, swissspidy, spacedmonkey, kadamwhite. Fixes #61970. git-svn-id: https://develop.svn.wordpress.org/trunk@59605 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [4275], [28785]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59606 602fd350-edb4-49c9-b593-d223f7449a82
See #61970. git-svn-id: https://develop.svn.wordpress.org/trunk@59607 602fd350-edb4-49c9-b593-d223f7449a82
… REST API endpoints. This bug could occur in `WP_REST_Posts_Controller`, `WP_REST_Global_Styles_Revisions_Controller`, `WP_REST_Revisions_Controller`, and any of their child classes. This changeset fixes it throughout. Props apermo, pbearne, hemant-ahir, flixos90. Fixes #62292. git-svn-id: https://develop.svn.wordpress.org/trunk@59630 602fd350-edb4-49c9-b593-d223f7449a82
Optimize the order of checking the various options caches in `get_option()` to prevent hitting external caches each time it is called for a known non-existent option. The caches are checked in the following order when getting an option: 1. Check the `alloptions` cache first to prioritize existing loaded options. 2. Check the `notoptions` cache before a cache lookup or DB hit. 3. Check the `options` cache prior to a DB hit. Follow up to [56595]. Props adamsilverstein, flixos90, ivankristianto, joemcgill, rmccue, siliconforks, spacedmonkey. Fixes #62692. See #58277. git-svn-id: https://develop.svn.wordpress.org/trunk@59631 602fd350-edb4-49c9-b593-d223f7449a82
…ite_getUsersBlogs()`. Follow-up to [https://mu.trac.wordpress.org/changeset/1218 mu:1218], [12852]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59632 602fd350-edb4-49c9-b593-d223f7449a82
Prior to this change a new session was unnecessarily created when a user changed their own password. Existing authentication cookies for the user will still be invalidated regardless of whether they share the same session token because session cookie keys contain a substring of the password hash. Props snicco, narenin, johnbillion Fixes #61366 git-svn-id: https://develop.svn.wordpress.org/trunk@59633 602fd350-edb4-49c9-b593-d223f7449a82
…d.php`. This aims to bring consistency with a similar fragment in other files, since relocating `wp-admin` or `wp-load.php` is not supported at this time. Follow-up to [6659], [7971], [8315]. Props hussain896, swissspidy, knutsp, SergeyBiryukov. Fixes #62809. git-svn-id: https://develop.svn.wordpress.org/trunk@59634 602fd350-edb4-49c9-b593-d223f7449a82
Old branches requiring outdated versions of Chromium to run JavaScript tests have recently started failing as a result of the `ubuntu-latest` container being updated to point to `ubuntu-24`. This introduces a new input to the reusable JavaScript testing workflow to allow a fix to be used without having to update Chromium or tests in these branches. Props swissspidy. See #62808. git-svn-id: https://develop.svn.wordpress.org/trunk@59635 602fd350-edb4-49c9-b593-d223f7449a82
This updates the admin color scheme `.sass` files to address some deprecated notices caused by upstream changes. - `string` and `colors` are no longer globally available functions. - `@import` is deprecated in favor of `@use`. There are still a few notices that are output, however this will require an update to the `grunt-sass` package to resolve. Props MattyRob. Fixes #62323. git-svn-id: https://develop.svn.wordpress.org/trunk@59656 602fd350-edb4-49c9-b593-d223f7449a82
Document that unserialised data types are stored as strings in the database and returned as such by the meta data functions. For example, setting meta data to the integer value `1` will be returned as `"1"` when subsequently queried via `get_metadata()` and the related functions. Props sukhendu2002, azaozz, jrf, rodrigosprimo. Fixes ticket:61950. git-svn-id: https://develop.svn.wordpress.org/trunk@59657 602fd350-edb4-49c9-b593-d223f7449a82
…on and WP-CLI commands. This reduces the noise of the output -- both locally and on CI -- when first pulling containers during local environment installation and the first time the cli container is pulled for WP-CLI commands. See #62280 git-svn-id: https://develop.svn.wordpress.org/trunk@59658 602fd350-edb4-49c9-b593-d223f7449a82
…d produces a non-zero exit code. When running a command that goes via docker.js and produces a non-zero exit code, the error message and stack trace from node an safely be hidden because the stack trace only points to the `execSync()` call and is of no use. Fixes #62814 git-svn-id: https://develop.svn.wordpress.org/trunk@59659 602fd350-edb4-49c9-b593-d223f7449a82
…teCategory()`. Follow-up to [20157], [32733]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59660 602fd350-edb4-49c9-b593-d223f7449a82
There are currently ~2,000 open pull requests on GitHub for `wordpress-develop`. Many of these were for testing changes that have already been merged. To help prevent orphaned pull requests, this new workflow will search for any pull requests referencing the `Fixed` Trac tickets as noted in the commit message and close them out. For now, this only happens for `push` events. Props peterwilsoncc, swissspidy, johnbillion, davidbaumwald. Fixes #62817. git-svn-id: https://develop.svn.wordpress.org/trunk@59661 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that when block context is filtered via `render_block_context`, the filtered value is provided as available context to inner blocks. For backwards compatibility reasons, filtered context is added to inner block context regardless of whether that block has declared support via the `uses_context` property. Props mukesh27, flixos90, gziolo, dlh, joemcgill, santosguillamot. Fixes #62046. git-svn-id: https://develop.svn.wordpress.org/trunk@59662 602fd350-edb4-49c9-b593-d223f7449a82
…k_ping()`. Follow-up to [2983], [55365]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59663 602fd350-edb4-49c9-b593-d223f7449a82
…rver` methods.
This resolves a few WPCS warnings:
{{{
Variable "$dateCreated" is not in valid snake_case format, try "$date_created"
}}}
Follow-up to [1563], [1659], [5888], [6691], [8543], [19848].
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59664 602fd350-edb4-49c9-b593-d223f7449a82
…er` methods.
This resolves a few WPCS warnings:
{{{
Variable "$isPrimary" is not in valid snake_case format, try "$is_primary"
}}}
Additionally, this commit renames `$catids` to `$cat_ids` for consistency.
Follow-up to [1671].
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59665 602fd350-edb4-49c9-b593-d223f7449a82
This prevents users of the SQLite Database Integration plugin from seeing untracked files in the `src/wp-content/database` directory. Props sukhendu2002, johnbillion Fixes #62813 git-svn-id: https://develop.svn.wordpress.org/trunk@59666 602fd350-edb4-49c9-b593-d223f7449a82
…nistration area. This changes some text to better match the guidelines and recommendations set forth in the make/core handbook, specifically: > the word “we” should be avoided (...) unless its made very clear which group is speaking Fixes #62295 git-svn-id: https://develop.svn.wordpress.org/trunk@59667 602fd350-edb4-49c9-b593-d223f7449a82
…e dev environment containers. This allows development tools to read the host path information from the `HOST_PATH` environment variable in order to, for example, map a path in a stack trace from the path in the container to the path on the host machine. Fixes #62833 git-svn-id: https://develop.svn.wordpress.org/trunk@59668 602fd350-edb4-49c9-b593-d223f7449a82
Props euthelup, johnbillion, mukesh27. Fixes #62822. git-svn-id: https://develop.svn.wordpress.org/trunk@59669 602fd350-edb4-49c9-b593-d223f7449a82
draganescu
added a commit
that referenced
this pull request
Jan 21, 2025
This reverts commit 3e2fb51.
draganescu
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )