Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed mode operation #4173

Open
3 of 9 tasks
chakaz opened this issue Nov 24, 2024 · 0 comments
Open
3 of 9 tasks

Managed mode operation #4173

chakaz opened this issue Nov 24, 2024 · 0 comments
Assignees
@chakaz

Comments

@chakaz
Copy link
Collaborator

chakaz commented Nov 24, 2024 •
edited
Loading

Some of our responses reveal information that, in a managed setup, should stay hidden.

Do not return replicas in CLUSTER sub-cmds (because replicas aren't reachable by clients):

  • CLUSTER NODES (emulated cluster)
  • CLUSTER NODES (real cluster)
  • CLUSTER SHARDS (emulated cluster)
  • CLUSTER SHARDS (real cluster)
  • CLUSTER SLOTS (emulated cluster)
  • CLUSTER SLOTS (real cluster)
  • INFO REPLICATION should return the real number of connected_slaves, but should not return the list of them
  • INFO SERVER should not return thread_count
  • INFO SERVER should also not reveal which architecture (arm/x86_64) it uses

All of the above should be only changed when some flag, say --managed_service_info is specified. Also, it should only apply for the regular port, while keeping admin port as is (i.e. reveal all info).
chakaz added a commit that referenced this issue Nov 24, 2024
@chakaz
chore: Hide replicas from CLUSTER subcmds in managed mode
7488120 
Part of #4173 (see for context)
@chakaz chakaz mentioned this issue Nov 24, 2024
Merged
chakaz added a commit that referenced this issue Nov 24, 2024
@chakaz
chore: Hide replicas from CLUSTER subcmds in managed mode (#4174)
6a7f345 
* chore: Hide replicas from `CLUSTER` subcmds in managed mode

Part of #4173 (see for context)

* server.client()
romange pushed a commit that referenced this issue Nov 24, 2024
@chakaz @romange
chore: Hide replicas from CLUSTER subcmds in managed mode (#4174)
49c39f5 
* chore: Hide replicas from `CLUSTER` subcmds in managed mode

Part of #4173 (see for context)

* server.client()
@chakaz chakaz self-assigned this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chakaz