chore: Hide replicas from CLUSTER subcmds in managed mode
#4174
+42
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #4173 (see for context)
romange
reviewed
Nov 24, 2024
tests/dragonfly/cluster_test.py
Outdated
| async def test_emulated_cluster_with_replicas(df_factory): | ||
| master = df_factory.create(port=BASE_PORT) | ||
| master = df_factory.create(port=BASE_PORT, admin_port=BASE_PORT + 1000) | ||
| replicas = [df_factory.create(port=BASE_PORT + i, logtostdout=True) for i in range(1, 3)] | ||
|
|
||
| df_factory.start_all([master, *replicas]) | ||
|
|
||
| c_master = aioredis.Redis(port=master.port) |
There was a problem hiding this comment.
please use master.client() and master.admin_client() instead of explicit aioredis.Redis. the latter handles the closing of the connections automatically.
There was a problem hiding this comment.
Done.
I had to make some changes to follow up on that, because the clients are configured slightly differently (utf8 decoding)
There was a problem hiding this comment.
yeah, you get it built in.
|
@chakaz yes, we should do the same for real cluster in future PRs. |
|
LGTM |
romange
approved these changes
Nov 24, 2024
romange
pushed a commit
that referenced
this pull request
Nov 24, 2024
* chore: Hide replicas from `CLUSTER` subcmds in managed mode Part of #4173 (see for context) * server.client()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4173 (see for context)
This fixes:
CLUSTER NODESCLUSTER SHARDSCLUSTER SLOTSBut only for emulated cluster mode. @romange - should we also handle real cluster (in a future PR)?