fix: performance degradation with Reflex matching #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Feb 20, 2025
romange
commented
- cherry-pick valkey security fixes with stringmatchlen with exponential complexity of stars See https://nvd.nist.gov/vuln/detail/cve-2022-36021
- Fallback to stringmatchlen for short lengths.
- Add another backend to GlobMatcher - PCRE2, though do not enable at the moment. While this backend is the fastest one - it requires an additional shared lib dependency.
|
Is PCR Perl Compatible Regular Expressions ? Never heard of it so I wanted to check it out |
romange
force-pushed
the
Pr5
branch
2 times, most recently
from
9b96a2c to
a38a8bf
Compare
kostasrim
reviewed
Feb 21, 2025
| * have just determined that there is no match for the rest | ||
| * of the pattern starting from anywhere in the current | ||
| * string. */ | ||
| *skipLongerMatches = 1; |
There was a problem hiding this comment.
Why is this used as a bool but is marked as int and passed as int * ?
There was a problem hiding this comment.
it's taken from valkey codebase.
src/core/glob_matcher.h
Outdated
Comment on lines
11
to
13
| #define FIX_PERFORMANCE_MATCHING | ||
|
|
||
| #ifndef FIX_PERFORMANCE_MATCHING |
There was a problem hiding this comment.
You first define FIX_PERFORMANCE and then you ifndef it. Isn't that a bug ?
There was a problem hiding this comment.
FIX_PERFORMANCE is a bad name.
it should be REFLEX_PERFORMANCE
1. cherry-pick valkey security fixes with stringmatchlen with exponential complexity of stars See https://nvd.nist.gov/vuln/detail/cve-2022-36021 2. Fallback to stringmatchlen for short lengths. 3. Add another backend to GlobMatcher - PCRE2, though do not enable at the moment. While this backend is the fastest one - it requires an additional shared lib dependency. Signed-off-by: Roman Gershman <[email protected]>
adiholden
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.