Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UpdatePersistentCacheTask for setting the value of persistent #449

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes several changes to the dfdaemon API, focusing on the refactoring of persistent cache task handling and the addition of new functionalities. The most important changes include the removal of WritePersistentCacheTask and ReadPersistentCacheTask methods and messages, the introduction of UpdatePersistentCacheTask methods and messages, and the corresponding updates in the gRPC client and server interfaces.

Refactoring of persistent cache task handling:

  • Removed WritePersistentCacheTask and ReadPersistentCacheTask messages and methods from pkg/apis/dfdaemon/v2/dfdaemon.proto and proto/dfdaemon.proto. [1] [2]
  • Removed WritePersistentCacheTask and ReadPersistentCacheTask methods from pkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go. [1] [2] [3] [4]

Addition of UpdatePersistentCacheTask functionality:

  • Added UpdatePersistentCacheTask message and method to pkg/apis/dfdaemon/v2/dfdaemon.proto and proto/dfdaemon.proto. [1] [2]
  • Added UpdatePersistentCacheTask method to the gRPC client and server interfaces in pkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go. [1] [2] [3] [4]

Version update:

  • Updated the version of the dragonfly-api package from 2.1.12 to 2.1.13 in Cargo.toml.

Related Issue

Motivation and Context

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 21, 2025
@gaius-qi gaius-qi self-assigned this Jan 21, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 21, 2025 14:09
@gaius-qi gaius-qi merged commit c7f8c2a into main Jan 21, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/update branch January 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant