-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] Backport changes to reduce nmethod size in code cache #89
Open
kuaiwei
wants to merge
1
commit into
dragonwell-project:master
Choose a base branch
from
kuaiwei:reduce_nmethod_review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuaiwei
force-pushed
the
reduce_nmethod_review
branch
from
July 25, 2024 06:16
e3bda63
to
ee047a5
Compare
kuaiwei
changed the title
[Backport] changes to reduce nmethod size in code cache
[JIT] Backport changes to reduce nmethod size in code cache
Jul 25, 2024
sandlerwang
approved these changes
Jul 25, 2024
linade
reviewed
Jul 29, 2024
linade
reviewed
Jul 29, 2024
This p2 issue might need to be backported as well: https://bugs.openjdk.org/browse/JDK-8331253 |
It has some regression on zgc and I need check it later. |
linade
approved these changes
Jul 31, 2024
kuaiwei
force-pushed
the
reduce_nmethod_review
branch
from
July 31, 2024 09:00
135f96f
to
fdc34d7
Compare
Summary: Include these changes partial backport of 8329332: Remove CompiledMethod and CodeBlobLayout classes [Backport] 8329433: Reduce nmethod header size [Backport] 8331087: Move immutable nmethod data from CodeCache Testing: CI testing Reviewers: Yude Lin, zhuoren.wz Issue: dragonwell-project#88
kuaiwei
force-pushed
the
reduce_nmethod_review
branch
from
July 31, 2024 09:17
fdc34d7
to
c8cd46b
Compare
Merge conflict is resolved. But I think it will add maintain burden in future merge. Keep it in reduce_method branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Include these changes
partial backport of 8329332: Remove CompiledMethod and CodeBlobLayout classes
[Backport] 8329433: Reduce nmethod header size
[Backport] 8331087: Move immutable nmethod data from CodeCache
Testing: CI testing
Reviewers: Yude Lin, zhuoren.wz
Issue: #88