Migration from the drand v1.5 codebase to its own repo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yolan Romailler <[email protected]>
Signed-off-by: Yolan Romailler <[email protected]>
Signed-off-by: Yolan Romailler <[email protected]>
CluEleSsUK
reviewed
Dec 8, 2023
|
|
||
| // Wrap provides a single entrypoint for wrapping a concrete client | ||
| // implementation with configured aggregation, caching, and retry logic | ||
| func Wrap(ctx context.Context, l log.Logger, clients []client.Client, options ...Option) (client.Client, error) { |
There was a problem hiding this comment.
imo it's worth adding another convenience constructor that takes []string addresses and just builds a verifying, speedtesting HTTP client for noobs to use
| if rr.err != nil { | ||
| oc.log.Infow("", "optimizing_client", "endpoint down when speed tested", "client", fmt.Sprintf("%s", rr.client), "err", rr.err) | ||
| } | ||
| stats = append(stats, rr.stat) |
There was a problem hiding this comment.
I think rr could be nil in some scenarios here, particularly on a context closing downstream
and moving grpc client to internals
now examples are provided using the Go test framework in the example_test.go files
Using the in-memory one instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with tests passing and relay seemingly working locally.