Skip to content

Commit

Permalink
Version 1.0.2 Release
Browse files Browse the repository at this point in the history
Fixed a couple of bugs. 1) The position was incorrect if the page
scrolled. 2) The z-index wasn't set, so sometimes the popup would be
behind other popups.
  • Loading branch information
drautb committed Jan 27, 2013
1 parent 0c677f5 commit 61ef383
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
1 change: 1 addition & 0 deletions bubble.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
top: 0;
width: 140px;
visibility: hidden;
z-index: 10000;
}

#ec-bubble-text {
Expand Down
10 changes: 8 additions & 2 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@
"manifest_version": 2,

"name": "Epoch Converter",
"description": "This extension will provide a popup showing a human readable date of a highlighted Unix timestamp.",
"version": "1.0",
"description": "Provides a popup showing a human readable date of a highlighted Unix timestamp.",
"version": "1.0.2",

"icons": {
"16": "icon.png",
"48": "icon.png",
"128": "icon.png"
},

"permissions": [

Expand Down
7 changes: 2 additions & 5 deletions selection.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
$(document).ready(function() {
$('body').append("<div id=\"ec-bubble\"><div id=\"ec-bubble-text\"></div><div id=\"ec-bubble-close\"></div></div>");

/*var closeIconUrl = chrome.extension.getURL("close.png");
alert(closeIconUrl);
$('#ec-bubble-close').css('background-image', "url('" + closeIconUrl + "');");*/
$('#ec-bubble-close').click(function() {
hideBubble();
});
Expand Down Expand Up @@ -57,8 +54,8 @@ function convertTimestamp(ts) {
}

function showBubble(e, text) {
$('#ec-bubble').css('top', e.clientY + 20 + "px");
$('#ec-bubble').css('left', e.clientX - 85 + "px");
$('#ec-bubble').css('top', e.pageY + 20 + "px");
$('#ec-bubble').css('left', e.pageX - 85 + "px");
$('#ec-bubble-text').html(text);
$('#ec-bubble').css('visibility', 'visible');
}
Expand Down

0 comments on commit 61ef383

Please sign in to comment.