Start the nonce count with value 1 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nounce count contains the number of times the client has sent the nonce value in the request (see Section 3.2.2 of RFC 2617). This should start with 1 because the initial request contains the value. Also, IIS 10.0 seems to ignore requests where nonce count is 0 and resends a "HTTP 401 Authorization Required" response.
|
This fixed an issue for me trying to talk to the MongoDB Atlas API. It would not authenticate until I used this patch. Do recommend merging. |
|
Also ran into this issue, is this project maintained? |
p-mongo
pushed a commit
to p-mongodb/faraday-digestauth
that referenced
this pull request
Apr 28, 2020
|
@p-mongo It doesn't seem like it. I am using a locally patched gem as a result, unfortunately. |
p-mongo
pushed a commit
to p-mongodb/faraday-digestauth
that referenced
this pull request
Sep 12, 2020
p-mongo
pushed a commit
to p-mongodb/faraday-digestauth
that referenced
this pull request
Sep 12, 2020
* speedup-auth-fix: rubocop Squelch rubocop complaints Reuse server nonces and account for drbrain/net-http-digest_auth#17 * require-user-and-pass: Require username and password to be not nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nounce count contains the number of times the client has sent the nonce value in the request (see Section 3.2.2 of RFC 2617). This should start with 1 because the initial request contains the value.
Also, IIS 10.0 seems to ignore requests where nonce count is 0 and resends a "HTTP 401 Authorization Required" response.