Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance and refactor table views #67

Merged
merged 23 commits into from
Nov 8, 2024
Merged

Enhance and refactor table views #67

merged 23 commits into from
Nov 8, 2024

Conversation

MytsV
Copy link
Collaborator

@MytsV MytsV commented Nov 8, 2024

Coupled with dream-aim-deliver/rage-ui-kit#43

  • Improve loading
  • Refactor and decompose
  • Enable toasts and handle all the possible errors

The improvements for the research context and chat pages will be coming next!

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
websat-planckster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 11:38am

return (
<SourceDataAGGrid isLoading={isSourceDataLoading} isUploading={false} enableUpload={false} rowData={sourceData} handleDownloadSourceData={handleDownloadSourceData} handleUploadSourceData={handleUploadSourceData} />
// eslint-disable-next-line @typescript-eslint/no-empty-function
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strongly suggest a need for changing the interface of the table component. This will be addressed in dream-aim-deliver/rage-ui-kit#45

@MytsV
Copy link
Collaborator Author

MytsV commented Nov 8, 2024

Fix #64

@MytsV MytsV linked an issue Nov 8, 2024 that may be closed by this pull request
1 task
@maany maany merged commit 812d515 into main Nov 8, 2024
6 checks passed
@maany maany deleted the general_page_enhancement branch November 8, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve loading placeholders
2 participants