Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): scrolling reaching limit judgment #4473

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

wubocao
Copy link
Contributor

@wubocao wubocao commented Jan 14, 2025

close #xxx

Added the scroll offset before the isLimitedStore judgment (the current logic makes isLimitedX and isLimitedY always false)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.72%. Comparing base (45a1c14) to head (8613e14).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/render-controllers/scroll.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4473      +/-   ##
==========================================
- Coverage   32.73%   32.72%   -0.02%     
==========================================
  Files        2599     2599              
  Lines      135187   135187              
  Branches    30093    30093              
==========================================
- Hits        44257    44236      -21     
- Misses      90930    90951      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 4b3dd11 into dream-num:dev Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants