Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): data validation support legal type validator #4560

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 23, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 23, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 23, 2025

Playwright test results

failed  1 failed
passed  23 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 27 seconds
commit  36d68be
info  For more information, see full report

Failed tests

chromium › smoking/mobile-s/mobile-s-smoking.spec.ts › ensure mobile-s boots up without errors

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 2.53165% with 231 lines in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (9fe3d2a) to head (36d68be).
Report is 18 commits behind head on dev.

Files with missing lines Patch % Lines
...dation-ui/src/services/dropdown-manager.service.ts 0.00% 120 Missing ⚠️
...s-ui/src/services/cell-dropdown-manager.service.ts 3.33% 29 Missing ⚠️
...eets-ui/src/views/dropdown/date-dropdown/index.tsx 4.76% 20 Missing ⚠️
...a-validation/src/validators/base-data-validator.ts 0.00% 15 Missing ⚠️
...eets-ui/src/views/dropdown/list-dropdown/index.tsx 7.14% 13 Missing ⚠️
...-ui/src/views/dropdown/cascader-dropdown/index.tsx 14.28% 6 Missing ⚠️
...ets-ui/src/views/dropdown/color-dropdown/index.tsx 16.66% 5 Missing ⚠️
packages/sheets-data-validation/src/index.ts 0.00% 4 Missing ⚠️
...alidation-ui/src/views/components/detail/index.tsx 0.00% 3 Missing ⚠️
...ta-validation/src/types/const/operator-text-map.ts 0.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4560      +/-   ##
==========================================
+ Coverage   32.63%   32.70%   +0.06%     
==========================================
  Files        2599     2602       +3     
  Lines      135059   135397     +338     
  Branches    30059    30158      +99     
==========================================
+ Hits        44080    44278     +198     
- Misses      90979    91119     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 requested review from Gggpound and wzhudev and removed request for Gggpound January 23, 2025 09:58
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests for the core.

@weird94 weird94 requested a review from jikkai as a code owner January 24, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants