Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statusbar): fix status bar can not read date type cell #4573

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

VicKun4937
Copy link
Contributor

@VicKun4937 VicKun4937 commented Jan 25, 2025

Copy link

github-actions bot commented Jan 25, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 8 seconds
commit  adeb39e
info  For more information, see full report

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 32.61%. Comparing base (49cd575) to head (adeb39e).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...sheets-ui/src/controllers/status-bar.controller.ts 0.00% 18 Missing ⚠️
...al/sheets-source-binding/src/model/source-model.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4573      +/-   ##
==========================================
- Coverage   32.62%   32.61%   -0.01%     
==========================================
  Files        2599     2599              
  Lines      135059   135081      +22     
  Branches    30060    30068       +8     
==========================================
  Hits        44059    44059              
- Misses      91000    91022      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 26, 2025
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 5, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants