-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upload snapshot as artifacts when test failed, record hean snapshot in mem test #4594
Conversation
e9fe5b6
to
fca05a7
Compare
View Deployment
|
fca05a7
to
8d3fb8a
Compare
Playwright test resultsDetails
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4594 +/- ##
=======================================
Coverage 32.71% 32.71%
=======================================
Files 2600 2600
Lines 135306 135305 -1
Branches 30141 30141
=======================================
Hits 44271 44271
+ Misses 91035 91034 -1 ☔ View full report in Codecov by Sentry. |
d56992c
to
2bc7866
Compare
dc3c7f5
to
4440ab2
Compare
d28ba22
to
b973702
Compare
b973702
to
fbf1406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #xxx
take two heapsnapshot in univer root path when run mem.spec.ts, and upload to artifacts if mem test failed
memory-first.heapsnapshot & memory-second.heapsnapshot
Pull Request Checklist