Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload snapshot as artifacts when test failed, record hean snapshot in mem test #4594

Merged
merged 8 commits into from
Feb 8, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 7, 2025

close #xxx

take two heapsnapshot in univer root path when run mem.spec.ts, and upload to artifacts if mem test failed

memory-first.heapsnapshot & memory-second.heapsnapshot

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku changed the title fix: mem snapshot fix: take mem snapshot in mem.spec when local run Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 34 seconds
commit  fbf1406
info  For more information, see full report

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.71%. Comparing base (3dc94a9) to head (fbf1406).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4594   +/-   ##
=======================================
  Coverage   32.71%   32.71%           
=======================================
  Files        2600     2600           
  Lines      135306   135305    -1     
  Branches    30141    30141           
=======================================
  Hits        44271    44271           
+ Misses      91035    91034    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku requested a review from hexf00 as a code owner February 8, 2025 03:18
@lumixraku lumixraku changed the title fix: take mem snapshot in mem.spec when local run fix: upload snapshot as artifacts when test failed, record hean snapshot in mem test Feb 8, 2025
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit fb3d10f into dev Feb 8, 2025
14 checks passed
@wzhudev wzhudev deleted the fix/mem-snapshot branch February 8, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants