Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): add remove func to serivce #4625

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

VicKun4937
Copy link
Contributor

  • add api

@VicKun4937 VicKun4937 requested a review from wzhudev as a code owner February 12, 2025 02:36
Copy link

github-actions bot commented Feb 12, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 12, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 32 seconds
commit  0534afa
info  For more information, see full report

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (aee23ec) to head (0534afa).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/sheets/src/services/range-theme-service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4625      +/-   ##
==========================================
+ Coverage   32.66%   32.68%   +0.01%     
==========================================
  Files        2603     2603              
  Lines      135482   135484       +2     
  Branches    30124    30124              
==========================================
+ Hits        44256    44277      +21     
+ Misses      91226    91207      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VicKun4937 VicKun4937 merged commit 6254c68 into dev Feb 13, 2025
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-range-theme-remove branch February 13, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants