Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): optimize resize observer and update toolbar item structure of Ribbon #4644

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Feb 14, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner February 14, 2025 08:43
Copy link

github-actions bot commented Feb 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai changed the title fix(ribbon): optimize resize observer and update toolbar item structure fix(ui): optimize resize observer and update toolbar item structure of Ribbon Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  d572a84
info  For more information, see full report

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 32.69%. Comparing base (0a0aafe) to head (d572a84).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/views/components/ribbon/Ribbon.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4644      +/-   ##
==========================================
- Coverage   32.71%   32.69%   -0.02%     
==========================================
  Files        2604     2604              
  Lines      135575   135576       +1     
  Branches    30157    30157              
==========================================
- Hits        44348    44327      -21     
- Misses      91227    91249      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 8e88ffd into dev Feb 14, 2025
9 checks passed
@jikkai jikkai deleted the fix/ribbon branch February 14, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants